style: Fix reimplemented-operator (FURB118) #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruff rule: https://docs.astral.sh/ruff/rules/reimplemented-operator/ Replaced lambdas with `operator.itemgetter()` or `operator.add()`. These are implemented more efficiently in C and have a Python fallback.
github-actions
bot
added
GUI
ninsbl
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/reimplemented-operator/
Replaced lambdas with
operator.itemgetter()oroperator.add(). These are implemented more efficiently in C and have a Python fallback. An answer on Stcak Overflow shows how sorted() and min() with a key using itemgetter can be 10-15% or 20-60% faster (on Python 3.6).I couldn't get a definitive answer, but some articles I've read explain that these functions, like itemgetter, can be pickable (requirement for being usable in multiprocessing on Windows/macOS and for Python 3.14), while lambdas are not (as the functions are pickled by name, and lambdas are anonymous and have the same name).